Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a markdown template for Pull Requests #243

Merged
merged 1 commit into from
Dec 6, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 31 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,31 @@
# Name of PR

### Your checklist for this pull request
Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

- [ ] Pull Request is small and focused on one topic so it can be reviewed easily
- [ ] Commit messages are detailed
- [ ] Code compiles correctly
- [ ] Documentation is updated to reflect changes (docstrings, comments, `/docs`)
- [ ] Added new tests to cover changes, especially when resolving an issue
- [ ] All tests pass in offline mode (the default)
- [ ] All tests pass when run with the `external_api` test option (if possible)

If you're adding a feature that makes network calls, remember to add new tests and
follow the test guideline documentation about offline and online testing.

### Description
Please describe your pull request.

What does this implement/fix? Explain.

Does this resolve any currently open issues?
If so, mention the issues, e.g. `Closes #xxx`, and Github will close them automatically
when your PR is merged into `main`.

Any relevant logs, error output, etc?

Any other comments? For example, will other contributors need to install new libraries
after picking up these changes?

💔Thank you!