Set verbose as the default behavior #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshoma
requested changes
Dec 6, 2023
oshoma
reviewed
Dec 7, 2023
| @@ -129,7 +134,7 @@ def get_response( | |||
| def file_event_handler(say, files, team_id, user_id, thread_ts, question): | |||
| if files[0]["size"] > cfg.FILE_SIZE_LIMIT: | |||
| say( | |||
| "Sorry, the file you attached is larger than 2mb. Please try again with a smaller file", | |||
There was a problem hiding this comment.
Not asking for a change at this time, but noting that we should really put FILE_SIZE_LIMIT (as MB) in the message here instead of hard-coding.
oshoma
previously approved these changes
Dec 8, 2023
|
@20001LastOrder I tweaked test names and corresponding test data files. Please resolve merge conflicts and then we're good to go. |
|
@oshoma Resolve the merge conflicts. It seems you'll need to approve it again. |
oshoma
approved these changes
Dec 8, 2023
|
@20001LastOrder confirming that this has not worked. just tested and didn't see the verbose behavior. re #248 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change the
--verboseflag to '--not-verbose` flag and make verbose logging as the default behavior.