Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix link and file scraper bug #286

Merged
merged 5 commits into from
Feb 29, 2024

Conversation

Eyobyb
Copy link
Collaborator

@Eyobyb Eyobyb commented Jan 30, 2024

correct the flow of code in the file.

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Additional steps for code with networking dependencies:

Description

This pr fixes the outdated llm model call. so that prompt contractor works
issue link https://linear.app/aggregate-intellect/issue/SHX-44/fix-file-and-url-prompt-issue

 correct the flow of code in the file.
@Eyobyb Eyobyb requested a review from saminegash January 30, 2024 13:22
@Eyobyb Eyobyb changed the title Update the outdated OpenAI model and, fix link and file scraper bug Jan 30, 2024
saminegash
saminegash previously approved these changes Feb 1, 2024
Copy link
Contributor

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@saminegash
Copy link
Contributor

Can you please make the resolve the conflict

@saminegash
Copy link
Contributor

Can you please make the resolve the conflict

@Eyobyb

@oshoma
Copy link
Collaborator

oshoma commented Feb 7, 2024

What issue does this fix? Please link to it / mention it in the PR.

@oshoma
Copy link
Collaborator

oshoma commented Feb 27, 2024

  1. What issue does this fix? Please link to it / mention it in the PR.
  2. Add a test to demonstrate the fix and ensure we don't have a regression in the future

Copy link
Contributor

@saminegash saminegash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Eyobyb Eyobyb merged commit e20db87 into Aggregate-Intellect:main Feb 29, 2024
@Eyobyb Eyobyb deleted the fix/link-file-prompting branch February 29, 2024 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants