You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add ability to configure any agent with hydra, includes:
type of agent
parameters for agents
actions for agents including configuring each action
validations for agents including configuring each validation
Also had a temporary fix for the GitHub readme extractor failure so now we have a clean test run.
Will create a separate PR for documentation on how to configure the agents.
Your checklist for this pull request
Thank you for submitting a pull request! To speed up the review process, please follow this checklist:
My Pull Request is small and focused on one topic so it can be reviewed easily
My code follows the style guidelines of this project (make format)
Commit messages are detailed
I have performed a self-review of my code
I commented hard-to-understand parts of my code
I updated the documentation (docstrings, /docs)
My changes generate no new warnings (or explain any new warnings and why they're ok)
I have added tests that prove my fix is effective or that my feature works
All tests pass when I run pytest tests (offline mode)
Additional steps for code with networking dependencies:
@20001LastOrder I notice the logic around team_id and user_id it is in a few functions that it shouldn't be in. For example SherpaOpenAI. I am thinking a class like SherpaOpenAI should accept a "unique user ID" as a parameter for token usage tracking, but it shouldn't know about Slack, team IDs, user IDs. wdyt? To me this feels like another issue needing some refactoring.
I notice the logic around team_id and user_id it is in a few functions that it shouldn't be in. For example SherpaOpenAI. I am thinking a class like SherpaOpenAI should accept a "unique user ID" as a parameter for token usage tracking, but it shouldn't know about Slack, team IDs, user IDs. wdyt? To me this feels like another issue needing some refactoring.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
20001LastOrder
force-pushed
the
hydra_config
branch
from
Description
Add ability to configure any agent with
hydra, includes:Also had a temporary fix for the GitHub readme extractor failure so now we have a clean test run.
Will create a separate PR for documentation on how to configure the agents.
Your checklist for this pull request
Thank you for submitting a pull request! To speed up the review process, please follow this checklist:
make format)/docs)pytest tests(offline mode)Additional steps for code with networking dependencies:
pytest tests --external_api(online mode, making network calls)