documentation for scrape and database #294
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oshoma
requested changes
Feb 20, 2024
There was a problem hiding this comment.
I LOVE this commit. Docs like this are super helpful.
Unfortunately it collides with recent changes to user usage tracker.
I suggest splitting into two commits: one for user usage tracker (redo the changes) and another for everything else (easy merge).
OR fix the user usage tracker changes in this PR and then everything else will be easy.
Also ... run make to format everything correctly.
Eyobyb
force-pushed
the
feature/documentation-for-scrape-and-database
branch
from
1e8485d to
43ac1e4
Compare
|
@Eyobyb let me know when you're ready for another review |
oshoma
force-pushed
the
feature/documentation-for-scrape-and-database
branch
from
ff314f0 to
62018f2
Compare
oshoma
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
documentation for scrape and database folder files.