Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run offline tests on every push and every pull request #322

Merged
merged 1 commit into from
Apr 15, 2024

Conversation

oshoma
Copy link
Collaborator

@oshoma oshoma commented Apr 3, 2024

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Additional steps for code with networking dependencies:

Description

Previously we would just run tests on pull requests against main. GitHub Actions usage is free for standard GitHub-hosted runners in public repositories, so we might as well test more comprehensively.

💔Thank you!

@20001LastOrder
Copy link
Collaborator

Should we restrict the push to only the main branch?

@oshoma
Copy link
Collaborator Author

oshoma commented Apr 9, 2024

@20001LastOrder I think testing on all branches is helpful.

If this was a private repo I would be more sparing, but in a public repo I think it's nice if all contributors can see test results quickly.

Previously we would just run tests on pull requests against main.
GitHub Actions usage is free for standard GitHub-hosted runners in public
repositories, so we might as well test more comprehensively.
@20001LastOrder 20001LastOrder self-requested a review April 15, 2024 04:26
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@20001LastOrder 20001LastOrder merged commit f1392d2 into Aggregate-Intellect:main Apr 15, 2024
1 check passed
@oshoma oshoma deleted the run-more-tests branch June 4, 2024 01:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants