Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug #332 and update instructions #333

Merged

Conversation

artificialfintelligence
Copy link
Contributor

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Description

Fixes bug #332 with the identified solution mentioned in the issue report.

@artificialfintelligence
Copy link
Contributor Author

artificialfintelligence commented Apr 6, 2024

@20001LastOrder I'd appreciate it if you or @Eyobyb could independently verify that the modified Dockerfile works correctly before merging.

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for updating the documentation. We are also trying to find a way to integrate this into the poetry install process.

@20001LastOrder 20001LastOrder merged commit 07d8848 into Aggregate-Intellect:main Apr 7, 2024
1 check passed
@artificialfintelligence
Copy link
Contributor Author

artificialfintelligence commented Apr 9, 2024

@20001LastOrder Speaking of Poetry, in the documentation, that step 6 that I added does not cover the Poetry installation route 😣 It will install outside the Poetry virtualenv. I forgot to include the alternative poetry run python -m spacy download en_core_web_sm (as with step 5 above it). Should I create a new branch and everything?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants