Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Pull Request template #345

Merged
merged 1 commit into from
Apr 20, 2024

Conversation

oshoma
Copy link
Collaborator

@oshoma oshoma commented Apr 20, 2024

Your checklist for this pull request

Thank you for submitting a pull request! To speed up the review process, please follow this checklist:

  • My Pull Request is small and focused on one topic so it can be reviewed easily
  • My code follows the style guidelines of this project (make format)
  • Commit messages are detailed
  • I have performed a self-review of my code
  • I commented hard-to-understand parts of my code
  • I updated the documentation (docstrings, /docs)
  • My changes generate no new warnings (or explain any new warnings and why they're ok)
  • I have added tests that prove my fix is effective or that my feature works
  • All tests pass when I run pytest tests (offline mode)

Additional steps for code with networking dependencies:

Description

Clarify the checklists and instructions.

Add "Change Type".

💔Thank you!

Clarify the checklists and instructions.

Add "Change Type".
@oshoma oshoma requested a review from amirfz April 20, 2024 14:48
@amirfz amirfz merged commit 30cb65f into Aggregate-Intellect:main Apr 20, 2024
1 check passed
@oshoma oshoma deleted the update-pr-template branch April 23, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants