-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
change the validation logic with regression validation logic, #357
Merged
20001LastOrder
merged 9 commits into
Aggregate-Intellect:main
from
Eyobyb:regration-validation-logic
Jun 3, 2024
Merged
change the validation logic with regression validation logic, #357
20001LastOrder
merged 9 commits into
Aggregate-Intellect:main
from
Eyobyb:regration-validation-logic
Jun 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Eyobyb
force-pushed
the
regration-validation-logic
branch
from
May 8, 2024 11:22
cb8213e
to
a14d29d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR, please check the comments below as well as the issue about regenerated text.
… validation step check count inside the validation
Eyobyb
force-pushed
the
regration-validation-logic
branch
from
May 29, 2024 12:29
2b6cbca
to
8c17cf4
Compare
20001LastOrder
approved these changes
Jun 3, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, well done!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
change the validation process with the regression validation which is explained here https://linear.app/aggregate-intellect/issue/SHX-59
Type of change
#SHX-59
Checklists
To speed up the review process, please follow these checklists:
Development
make format && make lint
)make test
)See the testing guidelines for help on tests, especially those involving web services.
Code review
💔 Thank you for submitting a pull request!