Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/upgrade langchain dependency from 0.0332 to 0.2.5 #394

Merged

Conversation

saminegash
Copy link
Contributor

Description

Describe your pull request here. What does this change implement or fix? Include motivation and context, e.g. relevant logs, error output, etc.

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@saminegash saminegash force-pushed the feature/upgrade-langchain-dependency-from-0.0332-to-0.2.5 branch from d5d4df5 to 7b2adbd Compare July 2, 2024 10:05
Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for getting the upgrade done! I think can really help us move forward with LangChain versions. Please check some minor questions above and I think we are good to merge this one.

src/apps/slackapp/log.txt Outdated Show resolved Hide resolved
src/apps/slackapp/slackapp/utils.py Outdated Show resolved Hide resolved
src/tests/unit_tests/test_error_handler.py Outdated Show resolved Hide resolved
@saminegash saminegash force-pushed the feature/upgrade-langchain-dependency-from-0.0332-to-0.2.5 branch from 96aee0c to d3016fe Compare July 22, 2024 11:09
@saminegash saminegash force-pushed the feature/upgrade-langchain-dependency-from-0.0332-to-0.2.5 branch from d3016fe to c0c476c Compare July 22, 2024 11:09
@20001LastOrder
Copy link
Collaborator

@saminegash Please see some responses above.

Copy link
Collaborator

@20001LastOrder 20001LastOrder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now

@20001LastOrder 20001LastOrder merged commit 87a2526 into main Aug 5, 2024
4 checks passed
@20001LastOrder 20001LastOrder deleted the feature/upgrade-langchain-dependency-from-0.0332-to-0.2.5 branch August 5, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants