Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add agent feedback policy #404

Merged
merged 5 commits into from
Aug 28, 2024

Conversation

20001LastOrder
Copy link
Collaborator

@20001LastOrder 20001LastOrder commented Jul 22, 2024

Description

Add policy that collects feedback from an agent before using the ReACT approach to select an action

Add directions for contributors. For example, do developers need to run poetry install after picking up these changes?

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Maintenance
  • New release

Related issues

Mention related GitHub and Linear issues. E.g. Closes #xxx or Fixes #xxx. Otherwise delete this section.

Checklists

To speed up the review process, please follow these checklists:

Development

  • The Pull Request is small and focused on one topic
  • Lint rules pass locally (make format && make lint)
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development (make test)
  • The changes generate no new warnings (or explain any new warnings and why they're ok)
  • Commit messages are detailed
  • Changed code is self-explanatory and/or I added comments
  • I updated the documentation (docstrings, /docs)
    See the testing guidelines for help on tests, especially those involving web services.

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached.
  • I have performed a self-review of my code
  • Issue from task tracker has a link to this pull request

💔 Thank you for submitting a pull request!

@20001LastOrder 20001LastOrder requested a review from amirfz July 22, 2024 04:26
@20001LastOrder
Copy link
Collaborator Author

@amirfz It seems that I can only assign a maintainer as the reviewer. So I assigned you to begin with.

@20001LastOrder 20001LastOrder linked an issue Aug 7, 2024 that may be closed by this pull request
AGENT_FEEDBACK_DESCRIPTION = """You are an intelligent assistant helping the user to complete their task. You have the following task to complete:

{options}

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don’t have any context for the question, how can the generated question be useful? For example, if I ask ‘What is the biggest?’ the question should specify ‘biggest what?’ or something similar.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Eyobyb I added the current task and context to the prompt. Could you check with the test case you have and also commit your test case to the test suite?

@20001LastOrder 20001LastOrder mentioned this pull request Aug 20, 2024
16 tasks
@20001LastOrder 20001LastOrder requested a review from Eyobyb August 20, 2024 20:59
@amirfz amirfz merged commit af7938d into Aggregate-Intellect:main Aug 28, 2024
1 check passed
@20001LastOrder 20001LastOrder deleted the agent_feedback_policy branch December 19, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Map user input into action / path and input
3 participants