reformulate query if the query is duplicate #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
20001LastOrder
requested changes
Aug 9, 2023
| @@ -150,6 +152,29 @@ def run(self, task: str) -> str: | |||
| action = self.output_parser.parse(assistant_reply) | |||
| print("action:", action) | |||
| tools = {t.name: t for t in self.tools} | |||
| if action == previous_action: | |||
| if action.name == "Search" or action.name == "Context Search": | |||
There was a problem hiding this comment.
I recommend we drop this condition since we may want to check duplication for all tools. (We don't need to worry about the finish tool for now as it will be separated and it will also break the loop)
| if action == previous_action: | ||
| if action.name == "Search" or action.name == "Context Search": | ||
| print("Action name: ", action.name, "\nStart reformulating the query") | ||
| instruction = ( |
There was a problem hiding this comment.
If I understand correctly, this prompt only asks for a different input for the same tool. Is this intended?
| f"Reformulated query:\n\n" | ||
| ) | ||
| openai.api_key = environ.get("OPENAI_KEY") | ||
| response = openai.Completion.create( |
There was a problem hiding this comment.
We may want to use self.llm so that we don't need to provide extra configurations of the LLM here
saminegash
reviewed
Aug 9, 2023
apps/slackbot/task_agent.py
Outdated
| @@ -150,6 +152,29 @@ def run(self, task: str) -> str: | |||
| action = self.output_parser.parse(assistant_reply) | |||
| print("action:", action) | |||
| tools = {t.name: t for t in self.tools} | |||
| if action == previous_action: | |||
| if action.name == "Search" or action.name == "Context Search": | |||
| print("Action name: ", action.name, "\nStart reformulating the query") | |||
|
As many of these changes do not influence the main functionality, I will merge this PR and make these required changes as new issues. |
|
please rebase this @YujingYang666777 |
20001LastOrder
approved these changes
Aug 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.