add feature flag 0x300 for tile engine #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`VDU 23,0,&C2,n` now checks whether the “tile engine” feature flag has been set before processing the command this will allow us to release the tile engine whilst the API is still in a state of potential flux
stevesims
commented
Jan 17, 2025
| @@ -10,7 +10,8 @@ | |||
| // #include "vdu_layers.h" | |||
| // in vdu_sys.h and is called by VDUStreamProcessor::vdu_sys_video() | |||
|
|
|||
| #define VDP_LAYERS 0xC2 // VDU 23,0,194 | |||
There was a problem hiding this comment.
this has been moved into agon.h to the block of code where all the other VDU 23,0 command numbers are defined
| @@ -395,6 +396,7 @@ | |||
| #define TESTFLAG_AFFINE_TRANSFORM 1 // Affine transform test flag | |||
|
|
|||
| #define FEATUREFLAG_FULL_DUPLEX 0x0101 // Full duplex UART comms flag | |||
| #define FEATUREFLAG_TILE_ENGINE 0x0300 // Tile engine flag (layers commands) | |||
There was a problem hiding this comment.
the choice of flag number here is slightly arbitrary, as there is not yet a standard for test/feature flag numbering - mostly because we have to few currently defined
here is a very rough proposal for a numbering standard:
| high-byte prefix | meaning |
|---|---|
| 00 | Buffered command extension settings / experimental test flags |
| 01 | Communications system settings/configuration |
| 02 | VDU system settings and configuration (see #265 ) |
| 03 | Graphics system extension settings (such as tile engine/layers) |
there's a draft PR #267 that currently uses 02xx numbered flags for some VDP protocol settings - those will be renumbered to use 01xx numbering.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
VDU 23,0,&C2,nnow checks whether the “tile engine” feature flag has been set before processing the commandthis will allow us to release the tile engine whilst the API is still in a state of potential flux