Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added health check request #48

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Conversation

Stefanpgr
Copy link
Contributor

Changes Made

Added a new endpoint "/ping" that returns 200 OK.

HTTP Method: GET

Request:
/ping

Response
The API will respond with an HTTP status code of 200 OK, and the response body will contain a message in a JSON key "message".

{
  "message": "pong"
}

This change will help developers see the health status of this service

@maxxfrazer
Copy link
Contributor

Thanks for adding this! It's in the readme, but somewhere along the refactor it was removed from the actual endpoints.

Could you add a small test to service/endpoints_test.go to keep the coverage up?

Also if you pull the latest changes the tests in the workflow will work on your fork.

@maxxfrazer maxxfrazer mentioned this pull request Dec 8, 2023
@maxxfrazer maxxfrazer changed the base branch from main to staging December 11, 2023 10:24
@maxxfrazer
Copy link
Contributor

Going to merge to staging and add the tests to get this out ASAP. Thanks again for the PR!

@maxxfrazer maxxfrazer merged commit 7ce0ee3 into AgoraIO-Community:staging Dec 11, 2023
1 check failed
@Stefanpgr
Copy link
Contributor Author

You are welcome anytime!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants