Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 0.7.0 #31

Merged
merged 6 commits into from
May 8, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# IRIS_WEB

## [0.7.0-pre](https://github.com/AgoraIO-Extensions/iris_web/compare/v0.5.0...v0.7.0-pre) (2024-03-19)


### Bug Fixes

* fix some event can not receive ([#30](https://github.com/AgoraIO-Extensions/iris_web/issues/30)) ([dc46c16](https://github.com/AgoraIO-Extensions/iris_web/commit/dc46c16fbbe2871a19cdc56453f12f5ff9f03093))

## [0.6.0](https://github.com/AgoraIO-Extensions/iris_web/compare/v0.5.0...v0.6.0) (2024-02-29)


2 changes: 1 addition & 1 deletion packages/fake/rtc/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "iris-web-rtc-fake",
"version": "0.6.0",
"version": "0.7.0",
"description": "wait",
"main": "./index.ts",
"scripts": {
2 changes: 1 addition & 1 deletion packages/rtc/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "iris-web-rtc",
"version": "0.6.0",
"version": "0.7.0",
"description": "wait",
"main": "./src/index.ts",
"scripts": {
4 changes: 2 additions & 2 deletions packages/rtc/src/engine/IrisRtcEngine.ts
Original file line number Diff line number Diff line change
@@ -158,16 +158,16 @@
`[callIrisApiAsync][result] ${func_name} ret ${ret.code}`
);
return ret;
} else {
AgoraConsole.error(
`[callIrisApiAsync][result] ${func_name} not found in ${className}Dispatch`
);

// TODO(guoxianze): Temporarily return ERR_NOT_SUPPORTED, for not implemented api.
return this.returnResult(
true,
false,
-NATIVE_RTC.ERROR_CODE_TYPE.ERR_NOT_SUPPORTED
);

Check warning on line 170 in packages/rtc/src/engine/IrisRtcEngine.ts

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🧾 Statement is not covered

Warning! Not covered statement
}

Check warning on line 171 in packages/rtc/src/engine/IrisRtcEngine.ts

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch
} else {
AgoraConsole.error(
@@ -176,7 +176,7 @@

// TODO(guoxianze): Temporarily return ERR_NOT_SUPPORTED, for not implemented module.
return this.returnResult(
true,
false,
-NATIVE_RTC.ERROR_CODE_TYPE.ERR_NOT_SUPPORTED
);
}
5 changes: 4 additions & 1 deletion packages/rtc/src/impl/IAgoraRtcEngineImpl.ts
Original file line number Diff line number Diff line change
@@ -73,7 +73,10 @@
AgoraTranslate.NATIVE_RTCAREA_CODE2AREAS(context.areaCode),
]);

if (context?.logConfig?.level) {
if (
typeof context?.logConfig?.level === 'number' &&

Check warning on line 77 in packages/rtc/src/impl/IAgoraRtcEngineImpl.ts

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch
context?.logConfig?.level >= 0

Check warning on line 78 in packages/rtc/src/impl/IAgoraRtcEngineImpl.ts

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch

Check warning on line 78 in packages/rtc/src/impl/IAgoraRtcEngineImpl.ts

GitHub Actions / Coverage annotations (🧪 jest-coverage-report-action)

🌿 Branch is not covered

Warning! Not covered branch
) {
this._engine.globalState.AgoraRTC.setLogLevel(
AgoraTranslate.NATIVE_RTCLOG_LEVEL2Number(context?.logConfig?.level)
);