Skip to content

Commit

Permalink
chore. update changelog
Browse files Browse the repository at this point in the history
  • Loading branch information
Matrixbirds committed Sep 24, 2019
1 parent 6773bf0 commit b375bb3
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
3 changes: 3 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
## THE CHANGELOG

#### 2.9.0-alpha.2
- fix ios dictionary stringValue type cast

#### 2.9.0-alpha.1
- fix typo: rename `methodisSpeakerphoneEnabled` to `isSpeakerphoneEnabled`
- events deprecated & instead:
Expand Down
8 changes: 4 additions & 4 deletions ios/RCTAgora/RCTAgora.m
Original file line number Diff line number Diff line change
Expand Up @@ -228,9 +228,9 @@ - (NSDictionary *)constantsToExport {
}
}
if (options[@"secret"] != nil) {
[self.rtcEngine setEncryptionSecret:[options[@"secret"] stringValue]];
[self.rtcEngine setEncryptionSecret:[options[@"secret"]]];
if (options[@"secretMode"] != nil) {
[self.rtcEngine setEncryptionMode:[options[@"secretMode"] stringValue]];
[self.rtcEngine setEncryptionMode:[options[@"secretMode"]]];
}
}

Expand Down Expand Up @@ -1374,7 +1374,7 @@ - (NSDictionary *)constantsToExport {
config.audioBitrate = [options[@"config"][@"audioBitrate"] integerValue];
config.audioChannels = [options[@"config"][@"audioChannels"] integerValue];

NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"] stringValue]
NSInteger res = [self.rtcEngine addInjectStreamUrl:[options[@"url"]]
config:config];
if (res == 0) {
resolve(nil);
Expand Down Expand Up @@ -1630,7 +1630,7 @@ - (NSDictionary *)constantsToExport {
transcoding.transcodingUsers = transcodingUsers;
}
if ([options objectForKey:@"transcodingExtraInfo"]) {
transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"] stringValue];
transcoding.transcodingExtraInfo = [options[@"transcodingExtraInfo"]];
}

NSInteger res = [self.rtcEngine setLiveTranscoding:transcoding];
Expand Down

0 comments on commit b375bb3

Please sign in to comment.