synthetic-chain package and CLI #46
Conversation
turadg
force-pushed
the
ta/import-synthetic-chain
branch
from
7c8ce52 to
69ba060
Compare
turadg
force-pushed
the
ta/import-synthetic-chain
branch
from
69ba060 to
6878544
Compare
turadg
force-pushed
the
ta/import-synthetic-chain
branch
from
6878544 to
ad4c45a
Compare
turadg
force-pushed
the
ta/import-synthetic-chain
branch
from
ad4c45a to
97fe8e8
Compare
|
|
||
| - name: build test images | ||
| run: | | ||
| docker info | ||
| ./buildTestImages.ts | ||
| node_modules/.bin/synthetic-chain build |
There was a problem hiding this comment.
Is it more idiomatic to do this?
| node_modules/.bin/synthetic-chain build | |
| yarn synthetic-chain build |
There was a problem hiding this comment.
Yes but that's not working. I'll take another crack at it after the other items
| "dependencies": { | ||
| "@agoric/synthetic-chain": "workspace:*" |
There was a problem hiding this comment.
I'm not familiar with workspace:*.
I suppose I should look it up...
| "proposals/**/*.js", | ||
| "proposals/**/*.ts", |
There was a problem hiding this comment.
These don't seem to be included in files in package.json. Is that by design?
There was a problem hiding this comment.
These globs are meant to get all files, independent of what's being published.
| languageName: node | ||
| linkType: hard | ||
|
|
||
| "@esbuild/android-arm64@npm:0.18.20": |
There was a problem hiding this comment.
I see esbuild pop up in our builds from time to time. I wonder what depends on it.
Here's hoping for a moment to check.
| @@ -8,6 +8,7 @@ | |||
| "type": "module", | |||
| "license": "Apache-2.0", | |||
| "dependencies": { | |||
| "@agoric/synthetic-chain": "file:./agoric-synthetic-chain-0.0.1-alpha.tgz", | |||
There was a problem hiding this comment.
There's a copy of this tar file in each proposals directory? I guess that makes sense...
There was a problem hiding this comment.
Once we're publishing to NPM then it can just pull from there. This is a stop gap
Description
This simplifies proposal authoring and maintenance. It's a necessary refactor to support Agoric/agoric-sdk#8605
Once this PR is landed, I'll follow up to,
@agoric/synthetic-chainable to pull from A3P and add proposals on top of it