Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: start_to_to.sh for backwards compat #94

Merged
merged 1 commit into from
Feb 7, 2024
Merged

fix: start_to_to.sh for backwards compat #94

merged 1 commit into from
Feb 7, 2024

Conversation

turadg
Copy link
Member

@turadg turadg commented Feb 7, 2024

#88 broke the tacit API of what files are in the Docker images available to downstream builds.

The downstream should be copying its own dependencies into the filesystem so that they aren't coupled to the @agoric/synthetic-chain used to produce the upstream images.

That's apparently not the case for some branch in agoric-sdk so this is a stop-gap until further investigation.

@turadg turadg requested a review from mhofman February 7, 2024 02:03
@mhofman
Copy link
Member

mhofman commented Feb 7, 2024

#88 broke the tacit API of what files are in the Docker images available to downstream builds.

The downstream should be copying its own dependencies into the filesystem so that they aren't coupled to the @agoric/synthetic-chain used to produce the upstream images.

That's apparently not the case for some branch in agoric-sdk so this is a stop-gap until further investigation.

agoric-sdk does nothing special but using version 0.0.4-3 of synthetic-chain. The problem I think is that synthetic-chain is expecting some files to be in the target image when preparing an upgrade?

Anyway, I triggered a manual workflow of this branch, which should build the use-* image. Once this completes, I'll re-run the failed agoric-sdk integration test, validating is this fix works, at which point I'll approve.

@turadg
Copy link
Member Author

turadg commented Feb 7, 2024

The problem I think is that synthetic-chain is expecting some files to be in the target image when preparing an upgrade?

Yes, the version of synthetic-chain in that branch. I'm not saying it's a bug in agoric-sdk, just that the behavior in that branch is expecting a file it shouldn't. It worked (until it didn't) but it wasn't meant to.

Once this completes, I'll re-run the failed agoric-sdk integration test, validating is this fix works, at which point I'll approve.

Good plan. Feel free to merge as well.

@mhofman
Copy link
Member

mhofman commented Feb 7, 2024

agoric-sdk test re-run passed.

@mhofman mhofman enabled auto-merge (squash) February 7, 2024 03:09
@mhofman mhofman merged commit e303fd0 into main Feb 7, 2024
2 checks passed
@mhofman mhofman deleted the 85-fixup branch February 7, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants