Skip to content

Commit

Permalink
chore(swingset): GC seems to be working better now
Browse files Browse the repository at this point in the history
Uncomment a test case that was disabled because of v8/xsnap
weirdness. Seems to work now.
  • Loading branch information
warner committed Dec 24, 2023
1 parent 11b1d7f commit 44a5aae
Showing 1 changed file with 1 addition and 5 deletions.
6 changes: 1 addition & 5 deletions packages/SwingSet/test/test-gc-kernel.js
Original file line number Diff line number Diff line change
Expand Up @@ -1165,12 +1165,8 @@ test('terminated vat', async t => {
c.queueToVatRoot('bootstrap', 'drop', [], 'panic');
await c.run();

// TODO: however, for some reason neither Node.js nor XS actually drops
// 'doomedExport1Presence', despite it clearly going out of scope. I don't
// know why. Until we can find way to make it drop, this check is commented
// out.
[refcounts, owners] = getRefCountsAndOwners();
// t.is(refcounts[doomedExport1Kref], undefined);
t.is(refcounts[doomedExport1Kref], undefined);
t.falsy(owners[doomedExport1Kref]);

t.is(refcounts[doomedExport2Kref], undefined);
Expand Down

0 comments on commit 44a5aae

Please sign in to comment.