Skip to content

Commit

Permalink
chore: weaken swingset dependency on vat-data to dev-dependency
Browse files Browse the repository at this point in the history
Swingset *tests* use `@agoric/vat-data`, but not `src/`, so this
changes swingset/package.json to list it in `devDependencies`, not
`dependencies`.

Meanwhile, `@agoric/vat-data` lists swingset in its `devDependencies`
for its own tests. This gives us a cycle of `devDependencies` but not
normal dependencies.

Code which imports vat-data must (generally) be running inside a vat,
which means the application that decided to put that code into a vat
probably depends upon swingset: it had to import
`makeSwingsetController` to create the housing. But the vat-data
-importing code doesn't know that, and doesn't need a direct
dependency on swingset, because it never imports anything from
swingset itself.
  • Loading branch information
warner committed Apr 12, 2022
1 parent e01a354 commit 81cee9c
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion packages/SwingSet/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,7 @@
"lint:eslint": "eslint '**/*.js'"
},
"devDependencies": {
"@agoric/vat-data": "^0.1.0",
"@endo/ses-ava": "^0.2.21",
"@types/tmp": "^0.2.0",
"ava": "^3.12.1",
Expand All @@ -34,7 +35,6 @@
"@agoric/store": "^0.6.10",
"@agoric/swing-store": "^0.6.5",
"@agoric/xsnap": "^0.11.2",
"@agoric/vat-data": "^0.1.0",
"@endo/base64": "^0.2.21",
"@endo/bundle-source": "^2.1.1",
"@endo/captp": "^2.0.3",
Expand Down

0 comments on commit 81cee9c

Please sign in to comment.