fixup! style(run-protocol): rename VaultState to VaultPhase

Agoric · Feb 23, 2022 · 837381e · 837381e
1 parent 5c29760
commit 837381e
Showing 1 changed file with 9 additions and 11 deletions.
diff --git a/packages/run-protocol/src/vaultFactory/vault.js b/packages/run-protocol/src/vaultFactory/vault.js
@@ -124,22 +124,20 @@ export const makeInnerVault = (
     zcf.makeEmptySeatKit(undefined);
 
   /** @type {VAULT_PHASE} */
-  let vaultPhase = VaultPhase.ACTIVE;
+  let phase = VaultPhase.ACTIVE;
 
   const assertVaultIsOpen = () => {
-    assert(vaultPhase === VaultPhase.ACTIVE, X`vault must still be active`);
+    assert(phase === VaultPhase.ACTIVE, X`vault must still be active`);
   };
 
   /**
    * @param {VAULT_PHASE} newPhase
    */
   const assignPhase = newPhase => {
-    const validNewPhases = validTransitions[vaultPhase];
+    const validNewPhases = validTransitions[phase];
     if (!validNewPhases.includes(newPhase))
-      throw new Error(
-        `Vault cannot transition from ${vaultPhase} to ${newPhase}`,
-      );
-    vaultPhase = newPhase;
+      throw new Error(`Vault cannot transition from ${phase} to ${newPhase}`);
+    phase = newPhase;
   };
 
   let outerUpdater;
@@ -316,10 +314,10 @@ export const makeInnerVault = (
     // [https://github.com/Agoric/dapp-token-economy/issues/123]
     const collateralizationRatio = await getCollateralizationRatio();
     /** @type {VaultUIState} */
-    const uiState = snapshotState(vaultPhase, collateralizationRatio);
+    const uiState = snapshotState(phase, collateralizationRatio);
     trace('updateUiState', uiState);
 
-    switch (vaultPhase) {
+    switch (phase) {
       case VaultPhase.ACTIVE:
       case VaultPhase.LIQUIDATING:
         outerUpdater.updateState(uiState);
@@ -329,14 +327,14 @@ export const makeInnerVault = (
         outerUpdater.finish(uiState);
         break;
       default:
-        throw Error(`unreachable vaultState: ${vaultPhase}`);
+        throw Error(`unreachable vaultState: ${phase}`);
     }
   };
   // XXX Echo notifications from the manager through all vaults
   // TODO move manager state to a separate notifer https://github.com/Agoric/agoric-sdk/issues/4540
   observeNotifier(managerNotifier, {
     updateState: () => {
-      if (vaultPhase !== VaultPhase.CLOSED) {
+      if (phase !== VaultPhase.CLOSED) {
         updateUiState();
       }
     },