fix: tighten bindAllMethods caller types

Agoric · Mar 15, 2023 · f04c118 · f04c118
1 parent 372d222
commit f04c118
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 6 deletions.
diff --git a/packages/SwingSet/src/vats/timer/vat-timer.js b/packages/SwingSet/src/vats/timer/vat-timer.js
@@ -934,7 +934,7 @@ export const buildRootObject = (vatPowers, _vatParameters, baggage) => {
    * replace the device), just in case that's useful someday
    *
    * @param {unknown} timerNode
-   * @returns {Promise<TimerService>}
+   * @returns {TimerService}
    */
   const createTimerService = timerNode => {
     timerDevice = timerNode;

diff --git a/packages/SwingSet/tools/passableEncoding.js b/packages/SwingSet/tools/passableEncoding.js
@@ -8,7 +8,7 @@ const noop = () => {};
 
 // TODO define these somewhere more accessible. https://github.com/endojs/endo/issues/1488
 /**
- * @typedef {Promise | import('@agoric/internal').Remotable} PassByRef
+ * @typedef {import('@endo/eventual-send').FarRef<unknown>} PassByRef
  * Gets transformed by a marshaller encoding.
  * As opposed to pass-by-copy
  */

diff --git a/packages/zoe/tools/internal-types.js b/packages/zoe/tools/internal-types.js
@@ -1,6 +1,6 @@
 /**
  * @typedef {object} ManualTimerAdmin
- * @property {(msg?: string) => Promise<void>} tick
+ * @property {(msg?: string) => void | Promise<void>} tick
  * @property {(nTimes: number, msg?: string) => Promise<void>} tickN
  */
 

diff --git a/packages/zoe/tools/manualTimer.js b/packages/zoe/tools/manualTimer.js
@@ -14,14 +14,13 @@ const { Fail } = assert;
 /**
  * @typedef {{
  *  timeStep?: import('@agoric/time/src/types').RelativeTime,
- *  eventLoopIteration?: () => Promise<unknown>,
+ *  eventLoopIteration?: () => void | Promise<void>,
  * }} ZoeManualTimerOptions
  */
 
 const nolog = (..._args) => {};
 
 /**
- *
  * A fake TimerService, for unit tests that do not use a real
  * kernel. You can make time pass by calling `advanceTo(when)`, or one
  * `timeStep` at a time by calling `tick()`.
@@ -62,7 +61,7 @@ const nolog = (..._args) => {};
 const buildManualTimer = (log = nolog, startValue = 0n, options = {}) => {
   const {
     timeStep = 1n,
-    eventLoopIteration = () => 0,
+    eventLoopIteration = () => {},
     ...buildOptions
   } = options;
   assert.typeof(timeStep, 'bigint');