Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build separate priceFeed coreEval for each target environment #10076

Closed
Chris-Hibbert opened this issue Sep 12, 2024 · 0 comments · Fixed by #10146
Closed

build separate priceFeed coreEval for each target environment #10076

Chris-Hibbert opened this issue Sep 12, 2024 · 0 comments · Fixed by #10146
Assignees
Labels
contract-upgrade enhancement New feature or request oracle Related to on-chain oracles.

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

#10074 prepares a new coreEval for the priceFeed release, which will update priceFeeds, scaledPriceAuthorities, auctions and vaults. Since it has to know the Oracle addresses and currencies at build time, it needs to be run separately for each target environment. While the code bundles should be identical, the proposals will be different for each one.

Description of the Design

Our runBook describes process that presume we can re-use the build artifacts across environments. We should document different processes that support this variation.

Security Considerations

This is more about robustness than security.

Scaling Considerations

N/A

Test Plan

We can use our tests across different platforms to validate that we have a process that is adaptable. Running the coreEval in mainFork that we intend to use on mainNet will show that we have the currencies right, but we'll have to carefully verify the oracle addresses.

Upgrade Considerations

It's all about upgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contract-upgrade enhancement New feature or request oracle Related to on-chain oracles.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants