build proposals for PriceFeed coreEvals on multiple platforms. #10146
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Chris-Hibbert
added
deployment
|
Are these included in the artifacts produced in ci as part of #9929 ? Looks like test-docker-build was Skipped. Want to add force-integration? Should I? |
No, but I can add that.
This doesn't change anything that would effect that, I think. Why would that be helpful? |
Deploying agoric-sdk with
|
| Latest commit: |
77a1aff
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://207d4dc4.agoric-sdk.pages.dev |
| Branch Preview URL: | https://10076-buildproposals.agoric-sdk.pages.dev |
|
based on ci gripes, it looks like we need to |
Okay, that took a couple of tries, but it's not complaining now. |
|
I grabbed the core-eval-scripts.zip from the ci job. I see just 1 |
dckc
reviewed
Sep 30, 2024
|
The strings in the package.json have changed. See this comment. |
Chris-Hibbert
force-pushed
the
9584-upgradePriceFeeds
branch
from
bf1bd0c
to
eb941d4
Compare
Chris-Hibbert
force-pushed
the
10076-buildProposals
branch
from
790be81
to
ed703d2
Compare
dckc
reviewed
Oct 10, 2024
a3p-integration/package.json
Outdated
| @@ -4,9 +4,11 @@ | |||
| "fromTag": "use-vaults-auctions" | |||
| }, | |||
| "scripts": { | |||
| "build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain", | |||
| "build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet", | |||
There was a problem hiding this comment.
I see only the 1 variant in the ci job Artifact:
$ unzip -l core-eval-scripts.zip |grep gov-price
1024 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-permit.json
1463 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-plan.json
7069 2024-10-10 01:41 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION.js
Is build:submissions the relevant thing to tweak rather than build?
dckc
approved these changes
Oct 10, 2024
| @@ -6,7 +6,9 @@ | |||
| "scripts": { | |||
| "build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain", | |||
| "build:sdk": "make -C ../packages/deployment docker-build-sdk", | |||
| "build:submissions": "scripts/build-all-submissions.sh", | |||
| "build:submissions": "scripts/build-all-submissions.sh && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet", | |||
There was a problem hiding this comment.
seems to work!
$ unzip -l core-eval-scripts.zip |grep gov-price
1436 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet-plan.json
1024 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet-permit.json
7195 2024-10-10 21:15 f-replace-price-feeds/devnet/gov-price-feeds-devnet.js
1024 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-permit.json
1463 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-plan.json
7069 2024-10-10 21:15 f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION.js
1024 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main-permit.json
1430 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main-plan.json
7284 2024-10-10 21:15 f-replace-price-feeds/main/gov-price-feeds-main.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10076
refs: #10074
Description
Build platform-dependent proposals for the PriceFeed coreEval.
For each platform (not counting A3P) defined in
updatePriceFeeds.js, a command is added, which invokesscripts/build-submission.shthree times to build each of the required proposals (updatePriceFeeds.js, add-auction.js, and upgradeVaults.js). The invocation for updatePriceFeeds takes a parameter specifying the platform.Security Considerations
N/A
Scaling Considerations
N/A
Documentation Considerations
Not user-visible
Testing Considerations
test on DevNet and MainFork
Upgrade Considerations
It's all about upgrade. This coreEval has code that varies depending on the collaterals and oracles present, so we have to build separate proposals for each platform.