Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build proposals for PriceFeed coreEvals on multiple platforms. #10146

Merged
merged 10 commits into from
Oct 10, 2024
Merged

build proposals for PriceFeed coreEvals on multiple platforms. #10146

Show file tree
Hide file tree
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
44542bf
feat: add commands to package.json to build proposals per platform
Chris-Hibbert Sep 24, 2024
0abd367
feat: archive the platform-specific artifacts on github.
Chris-Hibbert Sep 27, 2024
0a83ac7
chore: gitignore build artifacts
Chris-Hibbert Sep 28, 2024
8273a15
fixup! chore: gitignore build artifacts
Chris-Hibbert Sep 30, 2024
da31663
fixup! fixup! chore: gitignore build artifacts
Chris-Hibbert Sep 30, 2024
ed703d2
chore: leave the built artifacts in /submission/, with varying names.
Chris-Hibbert Sep 30, 2024
58732ac
chore: move platfrom-dependent builds to build:submissions
Chris-Hibbert Oct 10, 2024
b92c832
chore: drop "UNRELEASED_" from parameters
Chris-Hibbert Oct 10, 2024
b027c95
chore: move the artifacts for main and devnet to subdirs
Chris-Hibbert Oct 10, 2024
77a1aff
Merge branch 'master' into 10076-buildProposals
mergify[bot] Oct 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions a3p-integration/.gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,7 @@ proposals/*/.yarn/*
!proposals/*/.yarn/releases
!proposals/*/.yarn/sdks
!proposals/*/.yarn/versions

# build artifacts
proposals/*/mainNet/*
proposals/*/devNet/*
4 changes: 3 additions & 1 deletion a3p-integration/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,11 @@
"fromTag": "use-vaults-auctions"
},
"scripts": {
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain",
"build": "yarn run build:sdk && yarn run build:submissions && yarn run build:synthetic-chain && yarn run build:priceFeeds-for-mainnet && yarn run build:priceFeeds-for-devnet",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see only the 1 variant in the ci job Artifact:

$ unzip -l core-eval-scripts.zip |grep gov-price
     1024  2024-10-10 01:41   f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-permit.json
     1463  2024-10-10 01:41   f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION-plan.json
     7069  2024-10-10 01:41   f-replace-price-feeds/gov-price-feeds-A3P_INTEGRATION.js

Is build:submissions the relevant thing to tweak rather than build?

"build:sdk": "make -C ../packages/deployment docker-build-sdk",
"build:submissions": "scripts/build-all-submissions.sh",
"build:priceFeeds-for-mainnet": "scripts/build-submission.sh proposals/f:replace-price-feeds inter-protocol/updatePriceFeeds.js submission UNRELEASED_main; scripts/build-submission.sh proposals/f:replace-price-feeds vats/add-auction.js; scripts/build-submission.sh proposals/f:replace-price-feeds vats/upgradeVaults.js",
"build:priceFeeds-for-devnet": "scripts/build-submission.sh proposals/f:replace-price-feeds inter-protocol/updatePriceFeeds.js submission UNRELEASED_devnet; scripts/build-submission.sh proposals/f:replace-price-feeds vats/add-auction.js; scripts/build-submission.sh proposals/f:replace-price-feeds vats/upgradeVaults.js",
"build:synthetic-chain": "yarn synthetic-chain build",
"test": "yarn synthetic-chain test",
"doctor": "yarn synthetic-chain doctor"
Expand Down
5 changes: 4 additions & 1 deletion packages/builders/scripts/inter-protocol/updatePriceFeeds.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,10 @@ export default async (homeP, endowments) => {

const { writeCoreEval } = await makeHelpers(homeP, endowments);

await writeCoreEval('gov-price-feeds', (utils, opts) =>
const match = scriptArgs[0].match(/UNRELEASED_(.*)/);
const variant = match ? match[1] : scriptArgs;

await writeCoreEval(`gov-price-feeds-${variant}`, (utils, opts) =>
defaultProposalBuilder(utils, { ...opts, ...config }),
);
};
Loading