configure lint checking in a3p-integration #10238
Assignees
Labels
enhancement
New feature or request
Comments
Merged
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 16, 2024
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 16, 2024
Refs: Agoric/BytePitchPartnerEng#10 fix: formatting fixes and change requests fix(sync-tools): apply new linting rules and fix rebase conflicts Refs: Agoric#10238
anilhelvaci
added a commit
to bytepitch/agoric-sdk
that referenced
this issue
Oct 22, 2024
Refs: Agoric/BytePitchPartnerEng#10 fix: formatting fixes and change requests fix(sync-tools): apply new linting rules and fix rebase conflicts Refs: Agoric#10238
|
This isn't working right. Lint errors aren't failing CI. @michaelfig recently encountered https://github.com/Agoric/agoric-sdk/actions/runs/12681101195/job/35344144369#step:4:30 |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What is the Problem Being Solved?
We have coding standards for our source code, and it is supported by
yarn lintand enforced by CI checks. These checks are missing ina3p-integration, which makes it hard to request adherence to these conventions in third-party code we're paying for.Description of the Design
Make it possible to run
yarn lintin the proposals directories ina3p-integration, and enforce compliance with CI tests on PRs.Security Considerations
reviewing code is easier when it complies with standard formatting rules.
Scaling Considerations
None
Test Plan
Verify that enforcement catches the violations in #10171.
Upgrade Considerations
N/A
The text was updated successfully, but these errors were encountered: