Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove getBootstrapPayment() from Treasury #4021

Closed
Chris-Hibbert opened this issue Nov 3, 2021 · 2 comments
Closed

Remove getBootstrapPayment() from Treasury #4021

Chris-Hibbert opened this issue Nov 3, 2021 · 2 comments
Assignees
Labels
Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol security
Milestone

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

The Treasury has a method getBootstrapPayment() designed to provide RUN for the vbank at startup. It won't be needed once we have access to pre-existing RUN at chain startup.

Description of the Design

Remove the method and anything that refers to bootstrapPayment. There's a test, and code in install-on-chain and vats/src/bootstrap.js.

Security Considerations

It will be hard to convince reviewers and ourselves that there is nothing else using this functionality.

Test Plan

Not needed once the code is gone.

@Chris-Hibbert Chris-Hibbert added security XSmall Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol labels Nov 3, 2021
@Chris-Hibbert Chris-Hibbert added this to the Mainnet: Phase 1 - Treasury Launch milestone Nov 3, 2021
@Chris-Hibbert Chris-Hibbert self-assigned this Nov 3, 2021
@rowgraus rowgraus added the MN-1 label Jan 19, 2022
@Tartuffo
Copy link
Contributor

@Chris-Hibbert After various meetings, this ended up with a MN-1 tag AND in the Product Backlog pipeline (not MN-1 Backlog). Please modify appropriately for what it should actually be.

@dckc dckc self-assigned this Feb 5, 2022
@dckc
Copy link
Member

dckc commented Feb 5, 2022

This came up while working on #4165 ; the plan @michaelfig and I came up with is: make a single-purpose centralSupply contract that just mints the initial central supply based on supplyCoins from genesis and deposits it using the bankManager.

initial draft: 4c55bca, bb83419

@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@Tartuffo Tartuffo removed this from the Mainnet: Phase 1 - RUN Protocol milestone Feb 8, 2022
dckc added a commit that referenced this issue Feb 12, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 13, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 13, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 13, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 13, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 13, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
dckc added a commit that referenced this issue Feb 18, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
@mergify mergify bot closed this as completed in e526a7d Feb 22, 2022
dtribble pushed a commit that referenced this issue Feb 22, 2022
closes #4021

BREAKING CHANGE: removes getBootstrapPayment from VaultFactory
@Tartuffo Tartuffo added this to the Mainnet 1 milestone Mar 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Economy OBSOLETE in favor of INTER-protocol Inter-protocol Overarching Inter Protocol security
Projects
None yet
Development

No branches or pull requests

4 participants