Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

getRUN limitation: must be paid in full before being extended #4245

Closed
1 task done
dckc opened this issue Jan 4, 2022 · 3 comments
Closed
1 task done

getRUN limitation: must be paid in full before being extended #4245

dckc opened this issue Jan 4, 2022 · 3 comments
Assignees
Labels
BLD-Boost Issues relating to the BLD Boost contract and UI bug Something isn't working Core Economy OBSOLETE in favor of INTER-protocol cosmic-swingset package: cosmic-swingset Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival
Milestone

Comments

@dckc
Copy link
Member

dckc commented Jan 4, 2022

Describe the bug

In work such as #4092 that uses the so called attestation contract, the lien must be paid in full before it can be increased. This is an awkward limitation: a borrower might not have sufficient RUN on hand, but they may have enough BLD to back a larger loan. For example:

        Collateralization Ratio RUN Borrowed   Liened BLD RUN Rewards Accumulation RUN Purse
Test # Description User Action Required RUN per BLD Before After Before Delta After Staked BLD
3 Extending - more BLD required 100,600 -> 1600,10000 0.25 500%   100 1500 1600 10000

blocked by:

cc @dtribble @Chris-Hibbert

@dckc dckc added the bug Something isn't working label Jan 4, 2022
@dckc dckc assigned dckc and rowgraus Jan 4, 2022
@dckc
Copy link
Member Author

dckc commented Jan 6, 2022

@dtribble tells me he and @erights see a path to "semi-fungible" tokens, i.e. amounts where set items are paired with a Nat (iow: a bag).

@erights I look forward an issue about this. (p.s. #4361 is a relevant PR)

also, from Jan 4 discussion: One option that seems workable: Add “previous liened amount” to attestation amount. (and fold attestation into getRUN contract, find a new name, but keep it async)

@dckc
Copy link
Member Author

dckc commented Jan 8, 2022

@JimLarson notes some relevant tests / logic in some related go work; #3991 , I'm pretty sure.

@dckc dckc added Core Economy OBSOLETE in favor of INTER-protocol MN-1 BLD-Boost Issues relating to the BLD Boost contract and UI Inter-protocol Overarching Inter Protocol labels Jan 21, 2022
@Tartuffo Tartuffo added restival to be done before RUN Protocol Purple Team festival cosmic-swingset package: cosmic-swingset labels Jan 24, 2022
@Tartuffo Tartuffo removed the MN-1 label Feb 7, 2022
@rowgraus rowgraus removed their assignment Feb 11, 2022
@dckc
Copy link
Member Author

dckc commented Mar 3, 2022

Given #4361, this limitation went away during work on #3788.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BLD-Boost Issues relating to the BLD Boost contract and UI bug Something isn't working Core Economy OBSOLETE in favor of INTER-protocol cosmic-swingset package: cosmic-swingset Inter-protocol Overarching Inter Protocol restival to be done before RUN Protocol Purple Team festival
Projects
None yet
Development

No branches or pull requests

3 participants