Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move UI components out of agoric-sdk #6591

Closed
4 tasks done
turadg opened this issue Nov 18, 2022 · 1 comment · Fixed by #7922
Closed
4 tasks done

Move UI components out of agoric-sdk #6591

turadg opened this issue Nov 18, 2022 · 1 comment · Fixed by #7922
Assignees
Labels
enhancement New feature or request vaults_triage DO NOT USE

Comments

@turadg
Copy link
Member

turadg commented Nov 18, 2022

What is the Problem Being Solved?

UI development has different tooling and release requirements than the rest of agoric-sdk. https://github.com/Agoric/wallet-app/ was removed in #6511

There remains ui-components and web-components which weren't moved at the time because they need tooling to publish to NPM. agoric-sdk has all that built in but moving them out will require setting that up in another repo.

Related issues: #2320

Description of the Design

Start a new repo for client code that is used in UIs. No changes could break anything server-side so it would have much faster testing.

Migrate these packages to it,

  • @agoric/ui-components
  • @agoric/web-components

does it include CLI as well as GUI?

  • @agoric/agoric-cli

DECISION: no, that's too useful rn to agoric-sdk testing.

Security Considerations

Test Plan

New repo is https://github.com/Agoric/ui-kit

Tasks

Preview Give feedback
@turadg turadg added the enhancement New feature or request label Nov 18, 2022
@turadg turadg self-assigned this Nov 18, 2022
@otoole-brendan otoole-brendan added the vaults_triage DO NOT USE label Dec 20, 2022
@turadg
Copy link
Member Author

turadg commented Jun 9, 2023

For prioritization, example of PR bumping from merge queue due to flaky test for web-components: https://github.com/Agoric/agoric-sdk/actions/runs/5216063114/jobs/9414454901

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request vaults_triage DO NOT USE
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants