Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BREAKING CHANGE: remove @agoric/wallet-ui #6511

Merged
merged 2 commits into from
Oct 31, 2022
Merged

Conversation

turadg
Copy link
Member

@turadg turadg commented Oct 31, 2022

closes: #6474

Description

Per #6474, the Wallet app code is now at https://github.com/Agoric/wallet-app.

This PR removes it from agoric-sdk so that there is just one canonical Wallet UI. I believe that the instructions for using the older version compatible with ag-solo still work since they check out community-dev and not master. (Indeed, master wallet-ui is already broken for agsolo)

Security Considerations

Improves separation of builds and dependencies.

Documentation Considerations

End users are not affected.
Developers who wish to contribute to the Wallet app will need to know about the new repository. This commit message directs them.
Ag-solo users will need to use the instructions above to get an older version. (We've already decided agsolo doesn't need a GUI going forward).

Testing Considerations

CI

Copy link
Contributor

@samsiegart samsiegart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. We plan to add it to wallet-app before merging this right?
  2. Will we move web-components to a separate repo too as part of pull web UI out of agoric-sdk #6474?
  3. I wonder if there's now some things we can prune from yarn.lock. @mhofman might know better how to clean that up.
  4. I know @michaelfig was doing some stuff around ag-solo so I want to defer approval to him

@mhofman
Copy link
Member

mhofman commented Oct 31, 2022

Oh cleaning up yarn.lock would be much appreciated!

@turadg
Copy link
Member Author

turadg commented Oct 31, 2022

  1. We plan to add it to wallet-app before merging this right?

It's already there, per the first line of the description. Specifically: https://github.com/Agoric/wallet-app/tree/master

  1. Will we move web-components to a separate repo too as part of pull web UI out of agoric-sdk #6474?

That's not part of 6474. I'm not opposed but it would need some discussion as to where it goes and how it gets published.

  1. I wonder if there's now some things we can prune from yarn.lock. @mhofman might know better how to clean that up.

Good call. I meant to include that and forgot. Here's my local,

[6474-extract-wallet-app a53bf6480] chore: yarn install
 1 file changed, 239 insertions(+), 5496 deletions(-)

18536 lines down to 13729, 26% reduction. I'll hold off on push until approval since that's liable to get stale as master changes.

  1. I know @michaelfig was doing some stuff around ag-solo so I want to defer approval to him

Ok, I'll make him the sole reviewer.

@samsiegart
Copy link
Contributor

samsiegart commented Oct 31, 2022

It's already there, per the first line of the description. Specifically: https://github.com/Agoric/wallet-app/tree/master

Oh okay I had trouble finding it. Why master instead of main?

Copy link
Member

@michaelfig michaelfig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Can you please update yarn.lock as well?

@turadg turadg force-pushed the 6474-extract-wallet-app branch from 43255b8 to f1ce603 Compare October 31, 2022 21:30
@turadg turadg added automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR labels Oct 31, 2022
@mergify mergify bot merged commit 435a55c into master Oct 31, 2022
@mergify mergify bot deleted the 6474-extract-wallet-app branch October 31, 2022 21:50
@mhofman
Copy link
Member

mhofman commented Nov 1, 2022

Any reason integration was bypassed for this?
CI is now broken: https://github.com/Agoric/agoric-sdk/actions/runs/3365023455

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:no-update (expert!) Automatically merge without updates bypass:integration Prevent integration tests from running on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pull web UI out of agoric-sdk
4 participants