Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop reading denom purse balances from chainstorage #6788

Closed
3 tasks done
turadg opened this issue Jan 13, 2023 · 0 comments
Closed
3 tasks done

stop reading denom purse balances from chainstorage #6788

turadg opened this issue Jan 13, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request Epic needs-info not enough information given to reproduce / diagnose the problem vaults_triage DO NOT USE wallet

Comments

@turadg
Copy link
Member

turadg commented Jan 13, 2023

What is the Problem Being Solved?

A follow-on to #6652 is to stop writing purse balances to chain storage. wallet-app and dapp-psm rely on this currently. This ticket serves to organize keeping that functionality working through the Vaults Release.

Description of the Design

Basically read denom balances from Cosmos. The only purse that is read from chainstorage is Invitations.

Tasks

  1. automerge:rebase
    dckc
  2. samsiegart
  3. enhancement vaults_triage
    samsiegart

For the latter we could,

  1. Make dapp-psm read denom balances from Cosmos
  2. Make dapp-inter include PSM functionality (and read denom balances from Cosmos)
  3. Both

We've chosen option #2 for Vaults release, meaning that dapp-psm will stop working and users will have to use the PSM part of dapp-inter. If we end up needing a separate dapp-psm we can make it.

That was Jan 18. As of Jan 27 we opted for #1 instead because due to some other work that has landed #1 is cheaper than #2.

Security Considerations

Test Plan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Epic needs-info not enough information given to reproduce / diagnose the problem vaults_triage DO NOT USE wallet
Projects
None yet
Development

No branches or pull requests

2 participants