Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make vat-bank upgradeable #6849

Closed
2 tasks
dckc opened this issue Jan 25, 2023 · 1 comment
Closed
2 tasks

make vat-bank upgradeable #6849

dckc opened this issue Jan 25, 2023 · 1 comment
Labels
cosmic-swingset package: cosmic-swingset duplicate enhancement New feature or request ERTP package: ERTP wallet

Comments

@dckc
Copy link
Member

dckc commented Jan 25, 2023

What is the Problem Being Solved?

For the bulldozer upgrade (#6644), all vats need to be upgradeable (#5014). In particular, vat-bank.js, which reflects cosmos x/bank assets into ERTP using the JS/golang bridge.

Description of the Design

#6849 (comment)

Security Considerations

Handling failure modes and such is critical to conservation of assets.

Scaling Considerations

There is performance work scheduled for vat-bank:

It might be easier to do that before making it durable, since balance notifiers would go away.
Work to update clients to get balance updates another way (#6788) is coming soon, motivated by #6652 .

Test Plan

Null upgrade test a la #6715 .

cc @ivanlei @michaelfig @erights @warner

@dckc
Copy link
Member Author

dckc commented Jan 27, 2023

just re-discovered #5885 ; this is a dup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cosmic-swingset package: cosmic-swingset duplicate enhancement New feature or request ERTP package: ERTP wallet
Projects
None yet
Development

No branches or pull requests

2 participants