Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vaults subscribe to price updates continuously #6946

Closed
rowgraus opened this issue Feb 8, 2023 · 1 comment · Fixed by #7351
Closed

Vaults subscribe to price updates continuously #6946

rowgraus opened this issue Feb 8, 2023 · 1 comment · Fixed by #7351
Assignees
@Chris-Hibbert
Labels
vaults_triage DO NOT USE
Milestone
Vaults Functional...

Comments

@rowgraus
Copy link

rowgraus commented Feb 8, 2023

No description provided.

@rowgraus rowgraus added this to the Vaults Functional Testing milestone Feb 8, 2023
@ivanlei ivanlei added the vaults_triage DO NOT USE label Feb 13, 2023
@Chris-Hibbert
Copy link
Contributor

The current version of the Auction PR (#7000) has each auctionBook (one per collateral type) subscribing to price updates continuously, and using the most recently updated value when a price is needed. VaultManager, OTOH, requests a live price each time it's needed.

Chris-Hibbert added a commit that referenced this issue Apr 6, 2023
@Chris-Hibbert
refactor: Vaults get price updates continuously
8ddbee4 
closes: #6946

VaultManagers were already channeling a subscription to the
priceAuthority in order to store it off chain. This uses that feed
instead of requesting a fresh price when needed.
@Chris-Hibbert Chris-Hibbert mentioned this issue Apr 6, 2023
Merged
Chris-Hibbert added a commit that referenced this issue Apr 7, 2023
@Chris-Hibbert
refactor: Vaults get price updates continuously
df6575b 
closes: #6946

VaultManagers were already channeling a subscription to the
priceAuthority in order to store it off chain. This uses that feed
instead of requesting a fresh price when needed.
@mergify mergify bot closed this as completed in #7351 Apr 8, 2023
Chris-Hibbert added a commit that referenced this issue Apr 9, 2023
@Chris-Hibbert
refactor: Vaults get price updates continuously
a6af0c2 
closes: #6946

VaultManagers were already channeling a subscription to the
priceAuthority in order to store it off chain. This uses that feed
instead of requesting a fresh price when needed.
@turadg turadg mentioned this issue Jan 4, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
vaults_triage DO NOT USE
Projects
None yet
Milestone
Vaults Functional Testing
Development

Successfully merging a pull request may close this issue.

refactor: Vaults get price updates continuously Agoric/agoric-sdk
3 participants
@ivanlei @Chris-Hibbert @rowgraus