-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Liquidation proceeds are handled by Vault Manager #7123
Labels
Milestone
Comments
rowgraus
added
enhancement
New feature or request
Vaults
VaultFactor (née Treasury)
vaults_triage
DO NOT USE
labels
Mar 6, 2023
Chris-Hibbert
added a commit
that referenced
this issue
Mar 13, 2023
Chris-Hibbert
added a commit
that referenced
this issue
Mar 13, 2023
Chris-Hibbert
added a commit
that referenced
this issue
Mar 15, 2023
Chris-Hibbert
added a commit
that referenced
this issue
Mar 15, 2023
All tests pass with minor modifications. split test-vaultFactory. liquidation-related tests go to test-vaultLiquidation.js, others remain. refactor: revise liquidation payout approach to match #7123
Chris-Hibbert
added a commit
that referenced
this issue
Mar 15, 2023
All tests pass with minor modifications. split test-vaultFactory. liquidation-related tests go to test-vaultLiquidation.js, others remain. refactor: revise liquidation payout approach to match #7123
turadg
pushed a commit
that referenced
this issue
Mar 16, 2023
All tests pass with minor modifications. split test-vaultFactory. liquidation-related tests go to test-vaultLiquidation.js, others remain. chore: lint cleanups and other minor issues refactor: revise liquidation payout approach to match #7123 chore: changes requested in review chore: permit auctioneerKit for startVaultFactory chore: more changes suggested in review
turadg
pushed a commit
that referenced
this issue
Mar 16, 2023
All tests pass with minor modifications. split test-vaultFactory. liquidation-related tests go to test-vaultLiquidation.js, others remain. chore: lint cleanups and other minor issues refactor: revise liquidation payout approach to match #7123 chore: changes requested in review chore: permit auctioneerKit for startVaultFactory chore: more changes suggested in review fixup: remove getDepositInvitation from creatorFacet
Closed by #7000 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
What is the Problem Being Solved?
After a liquidation auction ends, some amount of IST and/or Collateral assets will be returned from auction to the vault manager. The vault manager will need to handle these assets appropriately.
By appropriately distributing proceeds, the vault manager will ensure that Inter Protocol's accounting remains robust, users have funds returned to the extent possible, and that the protocol reserve grows.
Description of the Design
There are two primary flows depending on whether the auction has raised enough IST to cover its debt.
Flow 1: Auction raises enough IST to cover debt
The following steps occur in this order
original collateral - collateral covering their share of debt (using average liquidation price) - collateral covering their share of the penalty (their debt / total debt * total penalty)
Flow 2: Auction does not raise enough to cover IST debt
This flow further bifurcates based on whether the auction has sold all its collateral asset and still has not covered the debt or has collateral remaining (which simply did not receive bidders)
Flow 2a: all collateral sold and debt is not covered
::sequence ends; no penalty is taken and vaults receive nothing back::
Flow 2b: collateral remains but debt is still not covered by IST raised by auction end
Note: there now should be debt remaining and possibly collateral remaining
Note, this ticket is written with the assumption that this logic is all handled in the vault manager. However, if it is more appropriate for some of this to live elsewhere, that is fine.
Security Considerations
Scaling Considerations
Test Plan
The text was updated successfully, but these errors were encountered: