Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create proposal for upgrade16 to replace all priceFeed vats #9370

Closed
Chris-Hibbert opened this issue May 15, 2024 · 0 comments · Fixed by #10317
Closed

create proposal for upgrade16 to replace all priceFeed vats #9370

Chris-Hibbert opened this issue May 15, 2024 · 0 comments · Fixed by #10317
Assignees
@Chris-Hibbert
Labels
contract-upgrade Emerynet test this in emerynet next-release about next agoric-sdk or endo release performance Performance related issues Testnet

Comments

@Chris-Hibbert
Copy link
Contributor

What is the Problem Being Solved?

#8400 reported that the priceFeed vats hold onto old quotes in their recoverySet, preventing them from being collected. #9013 made recoverySets optional. #8740 showed how to update the priceFeeds and their clients. #9283 applied the fixes to master. We have recent results showing that after these fixes, priceFeed vats and Zoe no longer grow as price updates are submitted.

image

Description of the Design

The next step is to apply the fixes from #9283 to an upcoming upgrade. (currently planned to be upgrade 16) Mainnet has different price feed vats, so the proposal will be different.

Security Considerations

N/A

Scaling Considerations

This is all about remediating a known problem on the running chain.

Test Plan

The approach has already been tested. We'll need to verify the script in a testNet, which will have yet other different priceFeeds.

Upgrade Considerations

Yes
@Chris-Hibbert Chris-Hibbert added enhancement New feature or request performance Performance related issues Testnet contract-upgrade next-release about next agoric-sdk or endo release Emerynet test this in emerynet labels May 15, 2024
@Chris-Hibbert Chris-Hibbert self-assigned this May 15, 2024
@Chris-Hibbert Chris-Hibbert removed the enhancement New feature or request label May 15, 2024
@warner warner mentioned this issue Jun 11, 2024
Open
@Chris-Hibbert Chris-Hibbert mentioned this issue Oct 22, 2024
Merged
@mergify mergify bot closed this as completed in #10317 Oct 25, 2024
mergify bot added a commit that referenced this issue Oct 25, 2024
@mergify
Turn priceFeed proposal into a SoftwareUpgrade (#10317)
5c932ce 
closes: #9370

## Description

The priceFeed proposal has been tested as an independent coreEval, but the current plan calls for it to be included in Upgrade 18. This adds it to `upgrade.go` and moves the tests to `n:upgrade-next`.

### Security Considerations

No additional security implications.

### Scaling Considerations

Addresses pre-existing scaling concerns (see #8400), and adds no new scaling issues.

### Documentation Considerations

None

### Testing Considerations

An existing test is moved to a new location.

The current version seems to tickle #10292, so tests may not pass at this point.

### Upgrade Considerations

Targeted for upgrade 18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Chris-Hibbert Chris-Hibbert

Labels
contract-upgrade Emerynet test this in emerynet next-release about next agoric-sdk or endo release performance Performance related issues Testnet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Turn priceFeed proposal into a SoftwareUpgrade Agoric/agoric-sdk
1 participant
@Chris-Hibbert