-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
iavl options and flags are not applied #9424
Labels
Comments
This was referenced May 30, 2024
mergify bot
added a commit
that referenced
this issue
May 31, 2024
closes: #9424 ## Description Plumb the iavl options into the cosmos baseapp. Copied by comparing to `DefaultBaseappOptions` in cosmos-sdk `server/util.go`, which we should likely use directly instead (see #9425), but this is a minimal change we can easily adopt now. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None. Change should explicitly be part of the release notes ### Testing Considerations Unsure about how to test this ### Upgrade Considerations Chain software, not consensus affecting.
mhofman
pushed a commit
that referenced
this issue
Jun 23, 2024
closes: #9424 ## Description Plumb the iavl options into the cosmos baseapp. Copied by comparing to `DefaultBaseappOptions` in cosmos-sdk `server/util.go`, which we should likely use directly instead (see #9425), but this is a minimal change we can easily adopt now. ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations None. Change should explicitly be part of the release notes ### Testing Considerations Unsure about how to test this ### Upgrade Considerations Chain software, not consensus affecting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
The different iavl options and flags are not passed into the app when starting. In particular, the
iavl-disable-fastnode=true
option currently has no effect.To Reproduce
TBD
Expected behavior
The iavl flags and options to be respected
Platform Environment
agoric-upgrade-15
Additional context
agoric-upgrade-14
upgraded cosmos-sdk to 0.46, which introduced new options and flags controlling iavl behavior. However these options require explicit plumbing through theappCreator
in agoric-sdk, which was not updated accordingly.Here is an example of another chain adding support for the config: crypto-org-chain/cronos#714
The text was updated successfully, but these errors were encountered: