Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

iavl options and flags are not applied #9424

Closed
mhofman opened this issue May 30, 2024 · 0 comments · Fixed by #9426
Closed

iavl options and flags are not applied #9424

mhofman opened this issue May 30, 2024 · 0 comments · Fixed by #9426
Assignees
@mhofman
Labels
agoric-cosmos bug Something isn't working state-sync state sync related

Comments

@mhofman
Copy link
Member

mhofman commented May 30, 2024

Describe the bug

The different iavl options and flags are not passed into the app when starting. In particular, the iavl-disable-fastnode=true option currently has no effect.

To Reproduce

TBD

Expected behavior

The iavl flags and options to be respected

Platform Environment

agoric-upgrade-15

Additional context

agoric-upgrade-14 upgraded cosmos-sdk to 0.46, which introduced new options and flags controlling iavl behavior. However these options require explicit plumbing through the appCreator in agoric-sdk, which was not updated accordingly.

Here is an example of another chain adding support for the config: crypto-org-chain/cronos#714
@mhofman mhofman added bug Something isn't working agoric-cosmos labels May 30, 2024
This was referenced May 30, 2024
Closed
Merged
@mhofman mhofman added the state-sync state sync related label May 31, 2024
@mhofman mhofman mentioned this issue May 31, 2024
Open
@mergify mergify bot closed this as completed in #9426 May 31, 2024
mergify bot added a commit that referenced this issue May 31, 2024
@mergify
Add support for iavl options in cosmos config (#9426)
074abce 
closes: #9424

## Description

Plumb the iavl options into the cosmos baseapp.

Copied by comparing to `DefaultBaseappOptions` in cosmos-sdk
`server/util.go`, which we should likely use directly instead (see
#9425), but this is a minimal change we can easily adopt now.

### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

None. Change should explicitly be part of the release notes

### Testing Considerations

Unsure about how to test this

### Upgrade Considerations

Chain software, not consensus affecting.
@mhofman mhofman self-assigned this Jun 3, 2024
mhofman pushed a commit that referenced this issue Jun 23, 2024
@mergify @mhofman
Add support for iavl options in cosmos config (#9426)
94f8967 
closes: #9424

## Description

Plumb the iavl options into the cosmos baseapp.

Copied by comparing to `DefaultBaseappOptions` in cosmos-sdk
`server/util.go`, which we should likely use directly instead (see
#9425), but this is a minimal change we can easily adopt now.

### Security Considerations

None

### Scaling Considerations

None

### Documentation Considerations

None. Change should explicitly be part of the release notes

### Testing Considerations

Unsure about how to test this

### Upgrade Considerations

Chain software, not consensus affecting.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mhofman mhofman

Labels
agoric-cosmos bug Something isn't working state-sync state sync related
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for iavl options in cosmos config Agoric/agoric-sdk
1 participant
@mhofman