-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
new snapshots export
command should fail early if exporting historical height
#9600
Labels
Comments
mhofman
added a commit
that referenced
this issue
Jul 1, 2024
closes: #9600 ## Description Check that an explicit height matches the latest height as exporting historical height is not supported by swing-store ### Security Considerations None ### Scaling Considerations None ### Documentation Considerations Release notes should make clear limits of new support ### Testing Considerations Manually tested explicit height ### Upgrade Considerations Would be good to include in u16 if we cut a new rc1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Describe the bug
#9563 replaced the cosmos
snapshots export
command to support it (#9100), but it too closely copied the height logic. Since the swing-store is not able to export a historical height, it should remove theheight
flags or error early if the height specified is not the latest height. Currently the export process will start and only error after the length cosmos side of the export completes.To Reproduce
agd snapsnhots export --height $someHistoricalHeight
Expected behavior
Early error preventing historical exports
The text was updated successfully, but these errors were encountered: