Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Release template build instructions fail to git clean submodules #9633

Closed
gibson042 opened this issue Jul 1, 2024 · 0 comments · Fixed by #9634
Closed

Release template build instructions fail to git clean submodules #9633

gibson042 opened this issue Jul 1, 2024 · 0 comments · Fixed by #9634
Labels
bug Something isn't working deployment Chain deployment mechanism (e.g. testnet) documentation Improvements or additions to documentation hygiene Tidying up around the house

Comments

@gibson042
Copy link
Member

Describe the bug

This was a contributing factor to #9614 (because build directories containing xsnap-worker executables were left in place), and has already been fixed in the agoric-upgrade-16-rc0 release.
@gibson042 gibson042 added the bug Something isn't working label Jul 1, 2024
gibson042 added a commit that referenced this issue Jul 1, 2024
@gibson042
fix: Update GitHub release template to document recursive git clean
35db4e5 
Fixes #9633

Also fixes a reference to the script to include its file extension.
gibson042 added a commit that referenced this issue Jul 1, 2024
@gibson042
fix(scripts): Update GitHub release template to document recursive `g…
e7a3d4b 
…it clean`

Fixes #9633

Also fixes a reference to the script to include its file extension.
@gibson042 gibson042 mentioned this issue Jul 1, 2024
Merged
@gibson042 gibson042 added documentation Improvements or additions to documentation deployment Chain deployment mechanism (e.g. testnet) hygiene Tidying up around the house labels Jul 1, 2024
@mergify mergify bot closed this as completed in #9634 Sep 12, 2024
@mergify mergify bot closed this as completed in f39d5fa Sep 12, 2024
mergify bot added a commit that referenced this issue Sep 12, 2024
@mergify
fix(scripts): Update GitHub release template to document recursive `g…
66e4cc0 
…it clean` (#9634)

closes: #9633
refs: #9614

## Description
Adds `git submodule foreach --recursive git clean -xdf` to build instructions in the release template.

### Security Considerations
None.

### Scaling Considerations
n/a

### Documentation Considerations
This PR updates documentation intended for node operators.

### Testing Considerations
n/a

### Upgrade Considerations
n/a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working deployment Chain deployment mechanism (e.g. testnet) documentation Improvements or additions to documentation hygiene Tidying up around the house
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(scripts): Update GitHub release template to document recursive git clean Agoric/agoric-sdk
1 participant
@gibson042