fix(liveslots): move passStyleOf from vatGlobals to inescapableGlobalProperties #10005
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibson042
approved these changes
Aug 30, 2024
Deploying agoric-sdk with
|
| Latest commit: |
e40a8b9
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://8585e882.agoric-sdk.pages.dev |
| Branch Preview URL: | https://warner-9981-passstyleof-ines.agoric-sdk.pages.dev |
…Properties
Previously, liveslots added the special `PassStyleOfEndowmentSymbol`
on `vatGlobals`. This enabled the first-level vat bundle (the one that
defines buildRootObject, e.g. ZCF) to use the same passStyleOf as
liveslots is using, with a real WeakMap for its memoization cache.
However, child Compartments of that vat, such as the ones contract
bundles are loaded into, do not automatically get the same global, and
ZCF does not pass any special options to `importBundle()`, which would
enable that.
This commit attaches the symbol to `inescapableGlobalProperties`,
rather than `vatGlobals`. Those properties are automatically (indeed
unavoidably) copied onto the `globalThis` of each child Compartment,
recursively. This is stronger than we need: we're ok with a
Compartment choosing to omit or change this property.
This allows contract code which does `import { passStyleOf } from
'@endo/pass-style'` to get the correct/fast/cheap version too.
Tests were added to liveslots to assert that it gives the expected
`inescapableGlobalProperties` option when asking the supervisor to
build the vat's namespace, and to SwingSet to assert that both child
and grandchild Compartments get the expected version of
passStyleOf (which was not the case for mere `vatGlobals`).
fixes #9981
warner
force-pushed
the
warner/9981-passStyleOf-inescapable-global
branch
from
4981bc0 to
e40a8b9
Compare
gibson042
approved these changes
Aug 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, liveslots added the special
PassStyleOfEndowmentSymbolonvatGlobals. This enabled the first-level vat bundle (the one that defines buildRootObject, e.g. ZCF) to use the same passStyleOf as liveslots is using, with a real WeakMap for its memoization cache.However, child Compartments of that vat, such as the ones contract bundles are loaded into, do not automatically get the same global, and ZCF does not pass any special options to
importBundle(), which would enable that.This commit attaches the symbol to
inescapableGlobalProperties, rather thanvatGlobals. Those properties are automatically (indeed unavoidably) copied onto theglobalThisof each child Compartment, recursively. This is stronger than we need: we're ok with a Compartment choosing to omit or change this property.This allows contract code which does
import { passStyleOf } from '@endo/pass-style'to get the correct/fast/cheap version too.fixes #9981