fix(liveslots): collection.clear(pattern) vs getSize #10008
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
f8806f3
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://63f9e408.agoric-sdk.pages.dev |
| Branch Preview URL: | https://warner-10007-collection-clea.agoric-sdk.pages.dev |
mhofman
approved these changes
Aug 31, 2024
Base automatically changed from
warner/8756-collection-deletion-gc-bug
to
master
August 31, 2024 01:40
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
The `.clear()` method, on (strong) collections, will delete all entries. But it can also be called with `keyPatt` and/or `valuePatt` argument, and only the matching entries will be deleted. Previously, the `|entryCount` metadata field was unconditionally set to zero for any call to `.clear()`, even those with patterns which caused some entries to be retained. This caused a subsequent `collection.getSize()` to return the wrong value, yielding zero even if the collection still had entries. This commit fixes the logic to decrement the `|entryCount` field by the number of entries actually deleted. As an optimization, it is still set directly to zero if `clear()` is not limited by patterns. fixes #10007
warner
force-pushed
the
warner/10007-collection-clear-pattern
branch
from
1c10d6d
to
f8806f3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
.clear()method, on (strong) collections, will delete all entries. But it can also be called withkeyPattand/orvaluePattargument, and only the matching entries will be deleted.Previously, the
|entryCountmetadata field was unconditionally set to zero for any call to.clear(), even those with patterns which caused some entries to be retained. This caused a subsequentcollection.getSize()to return the wrong value, yielding zero even if the collection still had entries.This commit fixes the logic to decrement the
|entryCountfield by the number of entries actually deleted. As an optimization, it is still set directly to zero ifclear()is not limited by patterns.fixes #10007