fix(swing-store): Delete transcript spans in stopUsingTranscript as in rollover #10060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
2d1e478
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://15223628.agoric-sdk.pages.dev |
| Branch Preview URL: | https://gibson-10054-stopusingtransc.agoric-sdk.pages.dev |
…dering, and values
(currently failing because stopUsingTranscript does not delete the previously-current span)
…and stopUsingTranscript
gibson042
force-pushed
the
gibson-10054-stopusingtranscript-delete-spans
branch
from
e26cbb2 to
2d1e478
Compare
mergify
bot
deleted the
gibson-10054-stopusingtranscript-delete-spans
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #10054
Description
The first commits from #10055, by request, culminating in a fix of #10054 by introducing a
closeSpanhelper to support both span rollover andstopUsingTranscript.Security Considerations
None known.
Scaling Considerations
If anything, a negligible reduction in transcriptStore size.
Documentation Considerations
None known.
Testing Considerations
Covered by unit tests.
Upgrade Considerations
This is kernel code that can be used at any node restart (i.e., because the configuration is consensus-independent, it doesn't even need to wait for a chain software upgrade).