feat(SwingSet): Support SLOG* environment variables when running tests #10061
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provides a
buildTestVatController
test helper that wrapsbuildVatController
in order to inject aslogSender
option as requested bySLOGFILE
/SLOGSENDER
/SLOGSENDER_AGENT
environment variables.Security Considerations
Minimal; this is testing code and nobody will be looking for a slog file they didn't request. The worst plausible scenario I can think of is someone having an exported environment variable and being surprised that running tests unexpectedly affects a file.
Scaling Considerations
n/a
Documentation Considerations
This is already documented at docs/env.md, but perhaps the "Affects:" details should be updated to mention SwingSet tests?
Testing Considerations
This is currently limited to the file where I needed it, but could easily cover much more.
Upgrade Considerations
n/a