Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(swingset): use xs-worker to avoid gc flake #10085

Merged
merged 2 commits into from
Sep 16, 2024

Conversation

mhofman
Copy link
Member

@mhofman mhofman commented Sep 13, 2024

closes: #10071

Description

I believe #8695 introduced a dependency of the boostrap vat of this test on the gc behavior of the engine, which makes it flaky. Applies the common fix to use an xs-worker instead.

Security Considerations

None

Scaling Considerations

None

Documentation Considerations

None

Testing Considerations

Hopefully the flake is gone

Upgrade Considerations

None

@mhofman mhofman added the automerge:squash Automatically squash merge label Sep 13, 2024
Copy link

cloudflare-workers-and-pages bot commented Sep 13, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 5466532
Status: ✅  Deploy successful!
Preview URL: https://262eab93.agoric-sdk.pages.dev
Branch Preview URL: https://mhofman-10071-fix-gc-test-fl.agoric-sdk.pages.dev

View logs

@mergify mergify bot merged commit a66b840 into master Sep 16, 2024
80 checks passed
@mergify mergify bot deleted the mhofman/10071-fix-gc-test-flake branch September 16, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:squash Automatically squash merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flake in SwingSet gc test
2 participants