feat(localOrchAccount): Deposit, Withdraw invitationMakers #10117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xpatrickdev
force-pushed
the
pc/send-anywhere-fixups
branch
3 times, most recently
from
99f89dc to
ea73ef7
Compare
0xpatrickdev
force-pushed
the
9193-deposit-withdraw-invitation-makers
branch
from
08488af to
81943fd
Compare
Deploying agoric-sdk with
|
| Latest commit: |
c92ef27
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://2dd11342.agoric-sdk.pages.dev |
| Branch Preview URL: | https://9193-deposit-withdraw-invita.agoric-sdk.pages.dev |
0xpatrickdev
commented
Sep 19, 2024
Comment on lines
+227
to
+241
| return watch( | ||
| zoeTools.localTransfer( | ||
| seat, | ||
| // @ts-expect-error LocalAccount vs LocalAccountMethods | ||
| this.state.account, | ||
| give, | ||
| ), | ||
| this.facets.seatExiterHandler, | ||
| seat, | ||
| ); | ||
| }, | ||
| 'Deposit', | ||
| undefined, | ||
| M.splitRecord({ give: AnyNatAmountsRecord, want: {} }), | ||
| ); |
There was a problem hiding this comment.
Given zoeTools.localTransfer is expected to resolve promptly, we technically do not need to use watch here and instead could use asVow.
This approach seems harmless, and appeases the linter. It also allows a developer to call Deposit() inside an async-flow if they wished.
0xpatrickdev
force-pushed
the
9193-deposit-withdraw-invitation-makers
branch
from
81943fd to
b2932ee
Compare
turadg
approved these changes
Sep 19, 2024
| @@ -180,3 +180,13 @@ export const TxBodyOptsShape = M.splitRecord( | |||
| nonCriticalExtensionOptions: M.arrayOf(M.any()), | |||
| }, | |||
| ); | |||
|
|
|||
| /** | |||
| * Ensures at least one {@link AmountKeywordRecord} entry is present and only | |||
There was a problem hiding this comment.
h/t SingleNatAmountRecord fka SingleAmountRecord from send-anywhere
|
Base branch is changed to master. Please re-run the integration tests by adding 'force:integration' label. |
- narrows typeguard as only NatAmounts are supported in send-anywhere
0xpatrickdev
force-pushed
the
9193-deposit-withdraw-invitation-makers
branch
from
b2932ee to
c92ef27
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refs: #9193
Description
Adds
DepositandWithdrawinvitationMakers toLocalOrchestrationAccount, leveragingZoeTools.localTransferandZoeTools.withdrawToSeatSecurity Considerations
Involves withdrawing payments to a temporary seat, which can be risky. Leverages
ZoeToolswhich rolls back allocations in failure and partial failure scenarios.Scaling Considerations
n/a
Documentation Considerations
I'm not sure how well we document the platform-provided
invitationMakersand.asContinuingOffer()helper. We might consider doing so in the future.Testing Considerations
Includes new unit tests. Wallet Driver tests in an e2e environment are coming in a future PR after #9966 lands
Upgrade Considerations
n/a, library code