fix(async-flow)!: stopgap E only for makeReplayMembraneForTesting
#10156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
fcc3dda
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://b3bf6ec9.agoric-sdk.pages.dev |
| Branch Preview URL: | https://mfig-async-flow-no-e.agoric-sdk.pages.dev |
mhofman
reviewed
Sep 25, 2024
Comment on lines
238
to
241
| if (optVerb === undefined) { | ||
| throw Panic`guest eventual call not yet supported: ${guestTarget}(${b(guestArgs)}) -> ${b(guestReturnedP)}`; | ||
| } else { | ||
| throw Panic`guest eventual send not yet supported: ${guestTarget}.${b(optVerb)}(${b(guestArgs)}) -> ${b(guestReturnedP)}`; |
There was a problem hiding this comment.
Can't we just replace the guestHandler with traps that do this? Possibly configured as an option when preparing the vow tools?
There was a problem hiding this comment.
I'm a bit confused by what you mean by "replace ... with traps". Are you talking about Proxy traps? Or eventual traps?
If eventual traps, that's exactly what the guestHandler already is.
michaelfig
changed the title
michaelfig
force-pushed
the
mfig-async-flow-no-e
branch
from
f807dbb to
ab33bad
Compare
michaelfig
changed the title
enableEventualSend option
michaelfig
force-pushed
the
mfig-async-flow-no-e
branch
from
ab33bad to
b9398d0
Compare
michaelfig
force-pushed
the
mfig-async-flow-no-e
branch
from
b9398d0 to
3b75e30
Compare
mhofman
reviewed
Oct 4, 2024
michaelfig
changed the title
enableEventualSend option
michaelfig
force-pushed
the
mfig-async-flow-no-e
branch
from
3b75e30 to
fcc3dda
Compare
michaelfig
changed the title
E only for makeReplayMembraneForTest
michaelfig
changed the title
E only for makeReplayMembraneForTestE only for makeReplayMembraneForTesting
mhofman
approved these changes
Oct 7, 2024
Comment on lines
+40
to
+46
| * @param {object} arg | ||
| * @param {LogStore} arg.log | ||
| * @param {Bijection} arg.bijection | ||
| * @param {VowTools} arg.vowTools | ||
| * @param {(vowish: Promise | Vow) => void} arg.watchWake | ||
| * @param {(problem: Error) => never} arg.panic | ||
| * @param {boolean} [arg.__eventualSendForTesting] CAVEAT: Only for async-flow tests |
There was a problem hiding this comment.
I wish there was an easier way to "extend" options while being able to use JSDoc to document the additional option (the only one I'm aware of is multiple typedef which is not clean)
michaelfig
added
the
automerge:no-update
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #9772
Description
To accomplish #9772, disable the stopgap eventual send support except when explicitly calling
makeReplayMembraneForTesting({..., __eventualSendForTesting: true }). We do this surgically to allow the membrane tests to prevent regression concerning the stopgap eventual-send guest support, and provide coverage for when we implement proper, always-on eventual-send support.Security Considerations
The replay membrane used by asyncFlow cannot be overridden, so the stopgap
Eoption is not available to users of asyncFlow, only to tests that are explicitly usingmakeReplayMembraneForTesting.Scaling Considerations
n/a
Documentation Considerations
n/a
Testing Considerations
n/a
Upgrade Considerations
None, provided the version of async flow before this PR has not yet been deployed.