Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(ERTP): balance {x, y, z} >= {z} #10309

Closed
wants to merge 1 commit into from
Closed

test(ERTP): balance {x, y, z} >= {z} #10309

wants to merge 1 commit into from

Conversation

dckc
Copy link
Member

@dckc dckc commented Oct 22, 2024

closes: #10292

depends on an endo fix:

to try a preview integration, we would use hash - endo-branch: master
but we want to test failure for a sec

Description

IOU

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

Copy link

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: b02f0d0
Status: ✅  Deploy successful!
Preview URL: https://d9a15747.agoric-sdk.pages.dev
Branch Preview URL: https://10292-isgte.agoric-sdk.pages.dev

View logs

@dckc
Copy link
Member Author

dckc commented Oct 22, 2024

huzzah!

ok 65 - unitTests › mathHelpers › copySetMathHelpers › balance {x, y, z} >= {z} %ava-dur=3ms

-- ci log

cc @frazarshad

@dckc dckc added the force:integration Force integration tests to run on PR label Oct 22, 2024
@dckc
Copy link
Member Author

dckc commented Oct 22, 2024

now I want to double-check that it fails with the old endo packages.

@dckc dckc removed the force:integration Force integration tests to run on PR label Oct 22, 2024
@kriskowal
Copy link
Member

Capturing this PR in #10316

To catch it breaking, remove the #endo-branch pin in the description and re-run the checks. I usually rebase and force-push for this effect, but there is a button somewhere in Github actions.

@dckc
Copy link
Member Author

dckc commented Oct 23, 2024

overtaken by #10316

@dckc dckc closed this Oct 23, 2024
@dckc dckc deleted the 10292-isgte branch November 23, 2024 00:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

odd {x, y, z} >= {z} failure in AmountMath.isGTE with AssetKind.SET
2 participants