Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update EC config for MAINNET #10323

Merged
merged 1 commit into from
Oct 24, 2024
Merged

Conversation

rabi-siddique
Copy link
Contributor

@rabi-siddique rabi-siddique commented Oct 23, 2024

closes: #10194

Description

The PR updates the MAINNET config for the replace electorate core eval by adding new EC member's wallet addresses to voterAddresses and updating highPrioritySendersConfig with addressesToRemove.

Security Considerations

Scaling Considerations

Documentation Considerations

Testing Considerations

Upgrade Considerations

@rabi-siddique rabi-siddique requested a review from a team as a code owner October 23, 2024 06:33
@rabi-siddique rabi-siddique changed the title chore: update config for MAINNET chore: update EC config for MAINNET Oct 23, 2024
Copy link

cloudflare-workers-and-pages bot commented Oct 23, 2024

Deploying agoric-sdk with  Cloudflare Pages  Cloudflare Pages

Latest commit: 478adb2
Status:🚫  Build failed.

View logs

@rabi-siddique rabi-siddique requested a review from dckc October 23, 2024 06:51
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

keys should be names for MAIN

to close #10194 , let's finalize all the configs, please - a3p and devnet should have the respective gov4 and a total of 3 after rotation.

Comment on lines 43 to 44
gov1: 'agoric1gx9uu7y6c90rqruhesae2t7c2vlw4uyyxlqxrx',
gov2: 'agoric1d4228cvelf8tj65f4h7n2td90sscavln2283h5',
gov3: 'agoric14543m33dr28x7qhwc558hzlj9szwhzwzpcmw6a',
gov1: 'agoric1d4228cvelf8tj65f4h7n2td90sscavln2283h5',
gov2: 'agoric13p9adwk0na5npfq64g22l6xucvqdmu3xqe70wq',
gov3: 'agoric1zayxg4e9vd0es9c9jlpt36qtth255txjp6a8yc',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The keys should be the names, not gov1 / gov2 / gov3.

"voterAddresses": {
"Jason Potts": "agoric1gx9uu7y6c90rqruhesae2t7c2vlw4uyyxlqxrx",
"Chloe White": "agoric1d4228cvelf8tj65f4h7n2td90sscavln2283h5",
"Thibault Schrepel": "agoric14543m33dr28x7qhwc558hzlj9szwhzwzpcmw6a",
"Chris Berg": "agoric13p9adwk0na5npfq64g22l6xucvqdmu3xqe70wq",
"Youssef Amrani": "agoric1el6zqs8ggctj5vwyukyk4fh50wcpdpwgugd5l5",
"Joe Clark": "agoric1zayxg4e9vd0es9c9jlpt36qtth255txjp6a8yc"

@rabi-siddique rabi-siddique requested a review from dckc October 24, 2024 04:12
Copy link
Member

@dckc dckc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd rather finish devnet and a3p configs in this pr, but I guess we can do it later

@rabi-siddique
Copy link
Contributor Author

rabi-siddique commented Oct 24, 2024

I'd rather finish devnet and a3p configs in this pr, but I guess we can do it later

Do we need to update the devnet config again? I think we made an update to it in #10251

As for the a3p config, Fraz is adding that in #10241

@rabi-siddique rabi-siddique added the automerge:rebase Automatically rebase updates, then merge label Oct 24, 2024
@rabi-siddique rabi-siddique force-pushed the rs-update-config-for-ec-changes branch from 220ce75 to baa9c96 Compare October 24, 2024 05:51
@rabi-siddique rabi-siddique added automerge:rebase Automatically rebase updates, then merge and removed automerge:rebase Automatically rebase updates, then merge labels Oct 24, 2024
@rabi-siddique rabi-siddique force-pushed the rs-update-config-for-ec-changes branch from baa9c96 to 478adb2 Compare October 24, 2024 10:06
@mergify mergify bot merged commit 91a5ada into master Oct 24, 2024
79 of 80 checks passed
@mergify mergify bot deleted the rs-update-config-for-ec-changes branch October 24, 2024 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
automerge:rebase Automatically rebase updates, then merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update hardcoded EC addresses with newly elected committee members
2 participants