test: provision wallet in PREPARE instead of USE #10461
Open
+3
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c365c94
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://f7403ee8.agoric-sdk.pages.dev |
| Branch Preview URL: | https://fraz-fix-a3p-provision-fail.agoric-sdk.pages.dev |
chore: added yarn install
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In a3p tests we added a new gov4 wallet and we provision it after the chain upgrade has executed. We also do this in emerynet, but it has been provisioned before the chain upgrade.
Since the proposal needs to send an invite to gov4, it waits for the wallet to be provisioned, then executes the latter part of the proposal, this waiting does not happen in emerynet and that is what causes the problem.
This PR fixes this problem by moving the provisioning step from USE stage to PREPARE stage, thereby provisioning it before the execution of the proposal
Security Considerations
Scaling Considerations
Documentation Considerations
Testing Considerations
Upgrade Considerations