Add allocation checks for asset reserve vat upgrade tests #10541
+5
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Deploying agoric-sdk with
|
| Latest commit: |
c0fd937
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://4f99f84c.agoric-sdk.pages.dev |
| Branch Preview URL: | https://iomekam-ar-upgrade-tests.agoric-sdk.pages.dev |
There was a problem hiding this comment.
That's a helpful test, but we shouldn't close #10399 until we have an upgrade set up in upgrade.go, and tests in a3p-integration.
One of the things I'm looking forward to seeing in a3p-integration is that the vstorage records look reasonable after the upgrade.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #10399
Description
As part of the upgrade all vat work, we want to ensure that this vat can be upgraded correctly. Luckily, there was already an upgrade test in place, but a scenario we were wary about was ensuring that assets survived the upgrade. I've added a quick check here to check the allocations after the upgrade.
Upgrade Considerations
Not relevant directly, but increases confidence in being able to upgrade this vat.