Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add tests for zoeHelper assertions #1771

Merged
merged 2 commits into from
Sep 16, 2020
Merged

Conversation

Chris-Hibbert
Copy link
Contributor

Remove skipped tests for remaining deleted helpers

fixes: #1652

Remove skipped tests for remaining deleted helpers

fixes: #1652
Copy link
Contributor

@katelynsills katelynsills left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There's a test.only, but assuming the tests pass with that removed, looks good. Does this cover all the methods?

t.falsy(assertIssuerKeywords(zcf, ['A', 'B']));
});

test.only(`zoeHelper with zcf - assertProposalShape`, async t => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missed a test.only

@Chris-Hibbert
Copy link
Contributor Author

Thanks for asking. I don't see tests for swapExact, assertUsesNatMath, or saveAllIssuers. The only one that concerns me is swapExact. I'll see about adding some tests for it. Probably won't make the cut-off.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Zoe package: Zoe
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ZoeHelpers Unit Tests
2 participants